Plugin full screen modals are broken on master branch

Start date

Due date

Description

Reproduce steps:

Expected:
Todo full screen modal appears

Observed:
Modal seems to be below the channel view, overflowing past the bottom of the screen

QA Test Steps

See description

Attachments

1

Activity

Show:

Jelena GilliamFebruary 11, 2022 at 9:51 PM

Tested and Passed on v6.4. Closing 

Jelena GilliamFebruary 1, 2022 at 4:09 PM

Tested and Passed on Cloud February 2nd 8679_9fce07ac_45c3cb95_634464ef.
QA note: Ticket will be closed after v6.4 testing.

Jesus EspinoDecember 15, 2021 at 9:32 AM

Yes, the main problem is you are using the CSS of the FullScreen modal, and now that css is only loaded whenever the fullscreen modal is loaded for first time. That in very specific places, so the CSS is not there, but you are still using it.

I going to add a fix for that. This is one of the reasons we need a components library that can be reused with the plugins. The lazy loading is important also.

Michael KochellDecember 14, 2021 at 5:10 AM

cc I haven’t had the time to pinpoint the commit that introduced this, but I think it’s very recent since daily currently doesn’t have the issue, but I’m able to reproduce on a fresh cloud server spun up from master.

Done
Pinned fields
Click on the next to a field label to start pinning.

Details

Assignee

QA Assignee

Reporter

Checklist

Created December 14, 2021 at 5:04 AM
Updated February 11, 2022 at 9:52 PM
Resolved January 28, 2022 at 2:47 PM