Improve join/leave messages

Start date

Due date

Description

Before starting work on this ticket, please check the GitHub help wanted issue first to see if anyone has started on it: https://github.com/mattermost/platform/issues/4755


A) Join/leave messages should:

  1. Never trigger a desktop notification unless you are mentioned by someone else (eg @lindsay added @asaad to the channel)

  2. Never trigger an “Unread” bolded channel name unless you are mentioned by someone else (eg @lindsay added @asaad to the channel)

B) Update the grammar for the messages:

  1. Switch the joined a channel message to say:
    @lindsay joined the channel.

  2. Switch the left a channel message to say:
    @lindsay left the channel.

  3. Switch the added to a channel message to say:
    @lindsay added @asaad to the channel.

C) Combine Consecutive join/leave messages

System messages related to joining, leaving, and adding/removing people from channels are combined into one post if they happen one after another, without any non-action messages in between. The messages are simply appended to the first message, and appear in the order that they occur.

Example:

@lindsay joined the channel. @lindsay added @asaad to the channel. @lindsay left the channel. @jason joined the channel.

QA Test Steps

No testing required.

Checklist

Activity

Show:

Lindy Isherwood May 21, 2018 at 5:25 PM

Thanks, closing. Noted no testing required. (was tested by QA on the PR spinmint)

Jason Blais May 1, 2018 at 5:28 PM

Good point. Updated fix version.

Linda Mitchell May 1, 2018 at 4:12 PM
Edited

Note: PR https://github.com/mattermost/mattermost-webapp/pull/1085#issuecomment-385692031 says this is moved to v4.11 (but that fix version doesn't appear in JIRA yet).

Elias Nahum January 9, 2018 at 5:52 PM

Complete spec needed

Saturnino Abril September 19, 2017 at 2:25 AM

Unresolved
Pinned fields
Click on the next to a field label to start pinning.

Details

Mana

Assignee

QA Assignee

Reporter

Fix versions

Sprint

Checklist

Created July 27, 2016 at 10:35 PM
Updated May 21, 2018 at 5:25 PM