new messages toast without replacing text

Description

on community daily with the macOS desktop app I noticed the new message toast was presenting the info without replacing any variables

QA Test Steps

None

Activity

Show:
Harrison Healey
March 31, 2021, 2:02 PM
Edited

From briefly investigating, it seems to render the raw text if one of the formatting value passed into the FormattedMessage isn’t included, but I can’t figure out how that would happen since even passing undefined doesn’t replicate that case.

Here’s the line where this message is used: https://github.com/mattermost/mattermost-webapp/blob/3e429f754d5b61c567f27b11f766b4a9574bde52/components/toast_wrapper/toast_wrapper.jsx#L224

When I forced it to happen locally by commenting out some stuff

, there was an error, but I think it’s only one that would show up when developing locally, not in production. I’ve attached a screenshot, so hopefully this isn’t totally misleading.

Guillermo Vayá
March 31, 2021, 9:50 AM
Guillermo Vayá
March 16, 2021, 9:30 AM

I can’t repro anymore, so I’ll close it and reopen if I figure out how to repro

Jesse Hallam
March 15, 2021, 8:10 PM

, by chance were there any other error logs around this? Does it reproduce?

Mana

None

Assignee

Guillermo Vayá

QA Assignee

None

Reporter

Guillermo Vayá

Epic Link

None

Fix versions

Mattermost Team

Web Platform

Labels

QA Testing Areas

None

GitHub Issue

None

Components

Severity

None