gitlab login not working in 4.6.1
Trying to log into mattermost through gitlab ends in a constant redirection trying to authenticate the browser.
most likely we are blocking a request that prevents the app to move forward.
Seems to work ok in browser-view branch, so most likely it is being blocked in the renderer.
original github issue:
QA Test Steps
Verify able to login using GitLab on desktop app. (tested PR build using RC cloud server with OAuth configured).
Tested and Passed on 4.6.2-rc1
Gitlab login works as expected.
QA note: No new test needed. Closing.
upon further investigation, it would have to be gitlab.com specific, there is a previous step that is needed to make it work so it needs:
so we can either add those as a rule for changing the UA (which only requires to remove Chrome and its version) or gitlab.com
since we can’t do something especific for cloud-flare, I’d prefer to just do this with gitlab, as /users/sign_in might be triggered in somewhere else.
We discussed this a bit further, and we're going to look at trying to spoof the UA automatically for anything with a `/cdn-cgi/` path since that should catch GitLab as well as hopefully anyone else using Cloudflare.
We also noticed that the UA puts Mattermost and Electron in between more common terms like Chrome and WebKit, so we could try shuffling those around to see if we're just violating some regex that expects them to come in a certain order. If that's the case, then we could just reorder the UA everywhere instead of just for Cloudflare routes.
test if rearanging the UA will just work
test without chrome at all, this only on host/cgi-bin
fake UA on host/cgi-bin
Web grooming: Guillermo, Devin, and myself to meet up to discuss possible solutions since I'm not happy with making it configurable.