Desktop: Prevent browser back/forward from firing in OAuth windows
Found while testing MM-18630.
QA Test Steps
1. Open Mattermost Desktop
2. Select a server with a plugin that requires an OAuth signin (example: GitHub)
3. In the center channel, type in '/github connect' or whatever command is necessary to trigger the OAuth window
4. With the OAuth window open, go to Menu > History > Back
5. The app should not crash or throw any JS errors.
Tested and Passed on 4.4.1 desktop app
Unable to move back/forward in history while the OAuth window (used Github) is open, no crash or JS errors.
QA note: New test added to Desktop testing spreadsheet. PR labeled. Closing.
New test created and linked in Jira above.
Plugin OAuths should open in a new popup. If I remember correctly,github should open in a popup.
Do you have a way to reproduce this bug? I tried it with the Jira plugin but it seems to work fine (tested on v4.4) and the Google API doesn’t open in a new window.