Desktop: Prevent browser back/forward from firing in OAuth windows

Description

Found while testing MM-18630.
A JavaScript error is thrown when trying to Back/Forward through an OAuth window.

QA Test Steps

1. Open Mattermost Desktop
2. Select a server with a plugin that requires an OAuth signin (example: GitHub)
3. In the center channel, type in '/github connect' or whatever command is necessary to trigger the OAuth window
4. With the OAuth window open, go to Menu > History > Back
5. The app should not crash or throw any JS errors.

Activity

Show:
Jelena Gilliam
April 15, 2020, 1:46 PM
Edited

Tested and Passed on 4.4.1 desktop app

  • Unable to move back/forward in history while the OAuth window (used Github) is open, no crash or JS errors.

QA note: New test added to Desktop testing spreadsheet. PR labeled. Closing.
New test created and linked in Jira above.

Daniel Espino Garcia
March 25, 2020, 2:52 PM

Plugin OAuths should open in a new popup. If I remember correctly,github should open in a popup.

Devin Binnie
March 25, 2020, 2:46 PM

Do you have a way to reproduce this bug? I tried it with the Jira plugin but it seems to work fine (tested on v4.4) and the Google API doesnโ€™t open in a new window.

Done
Your pinned fields
Click on the next to a field label to start pinning.

Assignee

Devin Binnie

QA Assignee

Jelena Gilliam

Reporter

Devin Binnie

Fix versions

Mattermost Team

Core Features

QA Testing Areas

OAuth

Components