Desktop/Webapp: a11y keyboard navigation within RHS is not navigating in expected order

Description

Since a11y navigation was added for all RHS panels in 5.15.2 (in addition to the already supported thread comments) navigation order from post to post has not been correct but instead has been jumping up/down seemingly randomly but only when using Desktop App v4.2.3 or below.

This can be seen on community.mattermost.com by doing a search for the word 'test' while using Desktop app v4.2.3. This can also be repro'd in a thread if there are a bunch of comments from various people with several [at]mentions – not sure if the [at]mentions play a role or not however.

QA Test Steps

Using Desktop App v4.2.x
1. Perform a search for a topic that is sure to return a bunch of posts
2. Use keyboard to navigate to RHS (F6) – top result should be highlighted first
3. Use up/down arrow keys to navigate from one result to the next – navigation should be sequential and not skip around randomly, navigation should *not* loop
3. Open up a *long* thread with multiple participants and [at]mentions
4. Use keyboard to navigate to RHS (F6) – bottom comment should be highlighted first
5. Use up/down arrow keys to navigate from one result to the next – navigation should be sequential and not skip around randomly, navigation *should* loop

Activity

Show:
Rohitesh Gupta
November 6, 2019, 12:32 PM

This ticket is tested on both v5.15.3-rc1 and v5.16.3 and is working fine. It is good to be patch released.

Dylan Haussermann
November 15, 2019, 4:49 AM

I believe this is working as expected…

  • Once I have he focus on the RHS (using F6) up and down arrow cycle up and down normally as expected

  • Tested this for both search result and opening a reply thread

  • For search results the top post is selected first

  • For reply thread the most recent post is selected 1st

One question: From the search results box I do have to push F6 three times to get to the RHS. The main thread and main input box regions are selected 1st. Is this expected?

Rohitesh Gupta
November 15, 2019, 12:24 PM

Tested on the latest 5.17 release build and it's working fine. Closing the ticket.

QA Notes:
Testcase added to the release spreadsheet. PR Labelled. Tested on 5.17.0-rc3 build.

Rohitesh Gupta
November 15, 2019, 12:26 PM

Hi

One question: From the search results box I do have to push F6 three times to get to the RHS. The main thread and main input box regions are selected 1st. Is this expected?

Yes this is expected. The way how it works is it always starts the focus from the last post on the main thread when we press F6. It does not matters where the current cursor focus is.

Done

Mana

None

Assignee

Dean Whillier

QA Assignee

Rohitesh Gupta

Reporter

Dean Whillier

Epic Link

None

Mattermost Team

Sustained Engineering

Sprint

None

QA Testing Areas

RHS

GitHub Issue

None

Components

None

Severity

None
Configure