Performance issues with fetching posts since scrolling overhaul changed queries.

QA Test Steps

1. Load up a channel with a long message history
2. Scroll back and forward in time. Ensure that messages load and that performance seems "good" in relation to past experience on that server. At least make sure that the delay to load messages doesn't seem extreme.

Activity

Show:
Gabe Jackson
July 17, 2019, 3:29 PM

I believe the next-steps of this issue are one of the following:

  1. Decide to push this change into master and let it soak on community-daily

  2. Go with something along the lines of what proposed in the performance channel: So I’m curious if it makes sense to push these changes back to the other get posts methods, assuming we see similar performance gains. Might be a nice win everywhere!

 

Gabe Jackson
July 22, 2019, 4:19 PM

Change merged into 5.14:

 

Working on 5.13 now.

Gabe Jackson
July 22, 2019, 5:31 PM

Change is now merged to 5.13 as well:

Linda Mitchell
July 25, 2019, 4:16 AM

It was determined that the soaking these changes did on master were the best test (test server won't have the data needed for a meaningful test). Closing. Release tests not needed, PR labeled.

Lindy Isherwood
July 27, 2019, 6:46 PM

Closing this off as per Linda's comment.

Done

Mana

None

Assignee

Gabe Jackson

QA Assignee

Lindy Isherwood

Reporter

George Goldberg

Epic Link

None

Fix versions

Mattermost Team

Sustained Engineering

Sprint

None

QA Testing Areas

Messages

GitHub Issue

None

Components

None

Severity

None
Configure