NPS telemetry reporting surveys are disabled if the setting has not been modified

Description

Seems the default value in the diagnostics for enable_nps_survey is false, so if the admin never changed it, it is reporting as not enabled.

The setting is defaulted to true and should reflect that in the data collection.

QA Test Steps

No testing required.

Activity

Show:
Harrison Healey
June 24, 2019, 7:59 PM

Fixed on master and cherry-picked to 5.12 and 5.13 branches

Ogi Marusic
June 25, 2019, 9:37 PM
Ogi Marusic
June 27, 2019, 7:56 PM
Edited

Verified by Eric with data from the upgrade server running 5.12.1.
Labelled the ticket ‘done-5.12.1’ and labelled the PR. Keeping in resolved to verify on 5.13.

Ogi Marusic
July 16, 2019, 9:06 PM
Edited

Verified with data from the upgrade.test server running 5.13. Closing.

Done

Mana

None

Assignee

Harrison Healey

QA Assignee

Ogi Marusic

Reporter

Eric Sethna

Epic Link

None

Fix versions

Mattermost Team

Core Features

Sprint

None

Labels

QA Testing Areas

Plugins

GitHub Issue

None

Components

None

Severity

None
Configure