NPS Plugin should not be enabled if telemetry is disabled

Description

Repro: Disable telemetry and upgrade to v5.12

Observed: NPS plugin is enabled but fails to start up, printing a log error

Expected: Do not enable the NPS plugin at all if telemetry is disabled on the server

QA Test Steps

When first upgrading to 5.12.1 or higher, the NPS plugin should be automatically enabled as long as EnableDiagnostics is set to true. When doing a fresh install on either of those versions, the NPS plugin should also be enabled.

Activity

Show:
Ogi Marusic
July 12, 2019, 8:04 PM

Tested and passed on 5.13

  • Tested upgrading from 5.11 to 5.13.0-rc2 with EnableDiagnostics set to “false” - NPS plugin was disabled

  • Tested upgrading from 5.11 to 5.13.0-rc2 with EnableDiagnostics set to “true” - NPS plugin was enabled

  • Tested with a fresh install of 5.13.0-rc2 - NPS plugin was enabled

Labelled the PR. Closing.

Ogi Marusic
June 25, 2019, 9:49 PM

Tested and passed on 5.12.1-rc1

  • Tested upgrading from 5.11 to 5.12.1 with EnableDiagnostics set to “false” - NPS plugin was disabled

  • Tested upgrading from 5.11 to 5.12.1 with EnableDiagnostics set to “true” - NPS plugin was enabled

  • Tested with a fresh install of 5.12.1 - NPS plugin was enabled

Labeled ‘done-5.12.1’ and leaving in Resolved to verify on 5.13.

 

Harrison Healey
June 19, 2019, 1:08 PM

Merged and cherry-picked to 5.12 and 5.13

Done
Your pinned fields
Click on the next to a field label to start pinning.

Assignee

Harrison Healey

QA Assignee

Ogi Marusic

Reporter

Eric Sethna

Fix versions

Mattermost Team

Core Features

QA Testing Areas

Plugins