Repro: Disable telemetry and upgrade to v5.12
Observed: NPS plugin is enabled but fails to start up, printing a log error
Expected: Do not enable the NPS plugin at all if telemetry is disabled on the server
When first upgrading to 5.12.1 or higher, the NPS plugin should be automatically enabled as long as EnableDiagnostics is set to true. When doing a fresh install on either of those versions, the NPS plugin should also be enabled.
Merged and cherry-picked to 5.12 and 5.13
Tested and passed on 5.12.1-rc1
Tested upgrading from 5.11 to 5.12.1 with EnableDiagnostics set to “false” - NPS plugin was disabled
Tested upgrading from 5.11 to 5.12.1 with EnableDiagnostics set to “true” - NPS plugin was enabled
Tested with a fresh install of 5.12.1 - NPS plugin was enabled
Labeled ‘done-5.12.1’ and leaving in Resolved to verify on 5.13.
Tested and passed on 5.13
Tested upgrading from 5.11 to 5.13.0-rc2 with EnableDiagnostics set to “false” - NPS plugin was disabled
Tested upgrading from 5.11 to 5.13.0-rc2 with EnableDiagnostics set to “true” - NPS plugin was enabled
Tested with a fresh install of 5.13.0-rc2 - NPS plugin was enabled
Labelled the PR. Closing.