Every channel switch triggers a fetch for users in all GM channels for the user

Description

Steps to Reproduce

1. Have one or more GM channels, even if auto-closed
2. Do one of the following

  • Channel switch between two non-GM channels

  • Focus the app/browser after a delay

Expected

1. No calls to api/v4/users?in_channel=<ā€¦>&page=0&per_page=8&sort= (unless this is the first page load)

Observed

1. API request against /api/v4/users?in_channel=<channel_id>&page=0&per_page=8&sort= for each GM channel. This gets worse with more GM channels, slamming both the server and client with rendering updates.

QA Test Steps

See steps to reproduce

Activity

Show:
Dylan Haussermann
December 31, 2018, 4:03 PM
Edited

For now, In have added this to release testing on Integrations tab that is covered by QA. Will follow-up with QA about where best to add this to release testing.

Closing task.

Dylan Haussermann
December 21, 2018, 2:57 AM

Tested and passed on 5.7 RC1 same behavior as noted on 5.6 RC3

Dylan Haussermann
December 19, 2018, 9:26 PM

Tested and passed on 5.6-RC3. This issue is resolved.

Calls to api/v4/users?in_channel=<ā€¦>&page=0&per_page=8&sort= appear on 1st page load as expected but are not visible every time the user switches channel.

Leaving this task in resolved to test 5.7 cherry-pick.

Done
Your pinned fields
Click on the next to a field label to start pinning.

Assignee

Jesse Hallam

QA Assignee

Dylan Haussermann

Reporter

Jesse Hallam

Mattermost Team

ABC

Sprint

None

QA Testing Areas

Direct and Group Messages